Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global symbol query #6497

Merged
merged 5 commits into from
Apr 13, 2018
Merged

Global symbol query #6497

merged 5 commits into from
Apr 13, 2018

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    d0635d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. Replace per-tile symbol querying with global queries.

    Addresses hover flicker from issues #5887 and #5506.
    Also fixes issue #5475/#6298, so that symbols that bleed over tile boundaries don't get missed. Under the hood, there are some good simplifications:
     - No round-tripping of viewport query coordinates through tile space
     - No more need to merge duplicate results from the same symbol showing up in multiple tiles
     - All querying-related data can now be indexed with a bucket instance id and a feature index
     - `Placement` now manages lifetime of any data needed to query against its CollisionIndex
     - CollisionBoxArray no longer involved in querying at all
    ChrisLoer committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    9434a4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4b1943 View commit details
    Browse the repository at this point in the history
  3. Use numeric sort comparator for sorting symbol query results.

    Matches topDownComparator of FeatureIndex.
    Previous behavior was string sorting, which could provide unexpected results with multi-digit feature indices.
    Update query tests to match new order.
    ChrisLoer committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    2d8d7e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc1a8a4 View commit details
    Browse the repository at this point in the history