Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug breaking transparency in fill layers with property functions #2971

Merged
merged 4 commits into from
Aug 10, 2016

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Aug 10, 2016

This bug is caused by draw_fill's inability to understand property functions when deciding whether to render in the opaque or translucent pass..

To mitigate, this PR draws all fills with property functions for fill-color or fill-opacity in the translucent pass.

fixes #2846

Checklist

@lucaswoj
Copy link
Contributor Author

Benchmarks

buffer: 938 ms
fps: 60 fps
frame-duration: 6.8 ms, 0% > 16ms
query-point: 0.93 ms
query-box: 48.36 ms
geojson-setdata-small: 10 ms
geojson-setdata-large: 100 ms

master Benchmarks

buffer: 1,013 ms
fps: 60 fps
frame-duration: 6.8 ms, 0% > 16ms
query-point: 0.79 ms
query-box: 44.77 ms
geojson-setdata-small: 10 ms
geojson-setdata-large: 98 ms

@lucaswoj lucaswoj merged commit e9287d8 into master Aug 10, 2016
@lucaswoj lucaswoj deleted the fill-layer-property-function branch August 10, 2016 16:53
@jfirebaugh
Copy link
Contributor

Did this also fix #2827 or #2828?

@lucaswoj
Copy link
Contributor Author

Yes. I am reasonably confident that both #2827 and #2828 were fixed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix fill-color property-function interpolation of alpha value
2 participants