Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include compiled mapbox-gl-style-spec package in mapbox-gl package #6574

Closed
anandthakker opened this issue Apr 27, 2018 · 0 comments
Closed

Comments

@anandthakker
Copy link
Contributor

We don't currently publish src/style-spec/dist/index.js with the main mapbox-gl package, so downstream projects (like @mapbox/studio) that use both gl-js and also specifically use the style-spec currently have to install mapbox-gl-style-spec separately. It would be preferable for them to be able to just pull in the style-spec from within the mapbox-gl package.

@anandthakker anandthakker added this to the 0.45.0 milestone Apr 27, 2018
@jfirebaugh jfirebaugh removed this from the 0.45.0 milestone Apr 30, 2018
anandthakker pushed a commit that referenced this issue May 1, 2018
anandthakker added a commit that referenced this issue May 3, 2018
Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17
anandthakker added a commit that referenced this issue May 3, 2018
* Fix style-spec build (#6575)

* Ensure style-spec is published with mapbox-gl (#6586)

Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17

* Bump style-spec version to 12.0.0-pre.1 (#6595)

* Use named exports in style-spec.js (#6602)

Cherry pick e83054f from master

Fixes #6601

* Ignore whole /dist/ directory

Done in master with e83054f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants