Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require heatmap-color to use expressions, not stop functions #5624

Closed
anandthakker opened this issue Nov 8, 2017 · 1 comment
Closed

Require heatmap-color to use expressions, not stop functions #5624

anandthakker opened this issue Nov 8, 2017 · 1 comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API
Milestone
v0.42

Comments

@anandthakker
Copy link
Contributor

This will be a breaking change, but with heatmaps having only just been released, its impact on existing users will hopefully be minimal. Adding this requirement allows us to avoid a handful of small hacks that were needed in order to trick ourselves into making a "zoom function" work properly for heatmap-color.
@anandthakker anandthakker added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Nov 8, 2017
@anandthakker anandthakker added this to the v0.42 milestone Nov 8, 2017
@jfirebaugh
Copy link
Contributor

Done in #5625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API
Projects
None yet
Milestone
v0.42
Development

No branches or pull requests
2 participants
@jfirebaugh @anandthakker