Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex text shaping #471

Closed
mikemorris opened this issue Jun 18, 2014 · 5 comments
Closed

Complex text shaping #471

mikemorris opened this issue Jun 18, 2014 · 5 comments
Assignees
@mikemorris

Comments

@mikemorris
Copy link
Contributor

Breaking this out from https://github.com/mapbox/gl-ported-maps/issues/20#issuecomment-43928958

Text shaping has moved client-side with switch to glyph ranges instead of augmented vector tiles, so complex text is no longer being shaped properly.

Proper text shaping:
casa

Currently backwards, and without complex text shaping:
screen shot 2014-05-29 at 1 12 33 pm
@mikemorris mikemorris self-assigned this Jun 18, 2014
@mikemorris
Copy link
Contributor Author

Useful info on HarfBuzz API design https://mail.gnome.org/archives/gtk-i18n-list/2009-August/msg00025.html

@mikemorris
Copy link
Contributor Author

Long, possibly useful thread on Mozilla integration of HarfBuzz https://bugzilla.mozilla.org/show_bug.cgi?id=449292

@mourner mourner added this to the future milestone Jun 24, 2014
@mikemorris mikemorris mentioned this issue Aug 19, 2014
Closed
@mourner mourner mentioned this issue Feb 10, 2015
Closed
@mikemorris mikemorris mentioned this issue Mar 24, 2015
Open
@jfirebaugh jfirebaugh removed this from the future milestone Jun 15, 2015
@fnicollet
Copy link
Contributor

I am also interested in this fix. I produce vector tiles with hebrew text only in Israel and users have been complaining that the text is reverted

@mikemorris mikemorris mentioned this issue Dec 9, 2015
Closed
@mikemorris
Copy link
Contributor Author

-> mapbox/DEPRECATED-mapbox-gl#4

@jimmont
Copy link

jimmont commented Apr 19, 2016

Hebrew labels look like nonsense until you realize they're flipped is there a solution I can implement now to resolve this for my gl-js map?

bensleveritt pushed a commit to bensleveritt/mapbox-gl-js that referenced this issue Oct 24, 2016
@samanpwbb
Merge pull request mapbox#471 from mapbox/[email protected]
c5b545b 
bump geojsonhint version to 2.0.0 and ignore (newly introduced) hint …
lucaswoj pushed a commit that referenced this issue Jan 11, 2017
@mourner @lucaswoj
Update GeoJSON source default values (#471)
5905f13 
* update GeoJSON source default values

* Copy edits
karimnaaji added a commit that referenced this issue Mar 14, 2023
@karimnaaji
Merge pull request #471 from mapbox/update-from-public
f232e92 
Merge from public repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemorris mikemorris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mourner @jfirebaugh @jimmont @mikemorris @fnicollet