Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "circle-blur" units be pixels #4099

Closed
lucaswoj opened this issue Feb 1, 2017 · 3 comments
Closed

Make "circle-blur" units be pixels #4099

lucaswoj opened this issue Feb 1, 2017 · 3 comments
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @mcwhittemore on November 12, 2015 17:8

@anandthakker raised a question today about if it is safe for circle blur to be greater than one. The spec is a bit unclear here as it only explains what the effect of 1 should be, leaving both < 1 and > 1 to be unclear.

Optional number. Defaults to 0.
Amount to blur the circle. 1 blurs the circle such that only the centerpoint is full opacity.

Looking into mapbox-gl-js circle-blur doesn't seem to be getting windowed which leads me to assume it is ok if it is greater than one. Is this right?

Either way we should update the spec to clear this kind of question up. The other blur's are in pixels, rather than an alpha channel.

Copied from original issue: mapbox/mapbox-gl-style-spec#378

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @mcwhittemore on December 2, 2015 15:31

@jfirebaugh any thoughts on this? Seems like < 0 shouldn't be allowed but greater than one should be. If 1 is the center point at full opacity than is 2 the center point at half opacity?

@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj
Copy link
Contributor Author

lucaswoj commented Feb 1, 2017

From @jfirebaugh on December 2, 2015 15:47

I'm not familiar with circle-blur. @tmcw or @ansis might know.

@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@jfirebaugh
Copy link
Contributor

Closing here; see #6584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.)
Projects
None yet
Development

No branches or pull requests

3 participants