Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump geojson-vt dep version #1600

Closed
Tracked by #229
kristfal opened this issue Oct 7, 2015 · 4 comments
Closed
Tracked by #229

Bump geojson-vt dep version #1600

kristfal opened this issue Oct 7, 2015 · 4 comments
Assignees

Comments

@kristfal
Copy link

kristfal commented Oct 7, 2015

Hey,

upstream fix for #1507 was fixed a while back, but hasn't been included in gl-js. Did a test build with 2.1.6 of geojson-vt and can verify that #1507 was resolved.

@mourner
Copy link
Member

mourner commented Oct 8, 2015

"^2.1.0" should install "2.1.6", so the next build should include the latest version. However we need to make sure to run npm update before publishing a version. cc @jfirebaugh @bhousel

@mourner mourner closed this as completed Oct 8, 2015
@jfirebaugh
Copy link
Contributor

We do automated release builds via CI and geojson-vt 2.1.6 should have been pulled into mapbox-gl 0.11.1. The problem is that CI has caching for node_modules, and even a new branch will pull the previous cache from master. So we need to switch the install step in CI to use npm update instead of npm install.

@lucaswoj
Copy link
Contributor

lucaswoj commented Nov 7, 2015

Looks like this has cased some bugs in v0.11.2 🙀 Going to try to fix the deploy script and publish a new version tonight.

@lucaswoj
Copy link
Contributor

Fixed as of #1683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants