Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark broken as it tries to load v7 styles and 0.9 requires v8 #1436

Closed
fnicollet opened this issue Aug 15, 2015 · 4 comments
Closed

Benchmark broken as it tries to load v7 styles and 0.9 requires v8 #1436

fnicollet opened this issue Aug 15, 2015 · 4 comments
Milestone

Comments

@fnicollet
Copy link
Contributor

Trying to run the benchmark, in site.js there is a reference to:
https://www.mapbox.com/mapbox-gl-styles/styles/bright-v7.json
Which produce

Uncaught Error: version: expected one of [8], 7 found

on benchmark page 1

Should the benchmark now be between 0.8 and 0.9?

Thanks

@fnicollet
Copy link
Contributor Author

Note that if changed manually to v8, it still crashes as this file does not exist:
https://www.mapbox.com/mapbox-gl-styles/styles/bright-v8.json
even if it exists in the mapbox-gl-styles repo:
https://github.com/mapbox/mapbox-gl-styles/blob/master/styles/bright-v8.json

Looks like the release of 0.9 wasn't sync with other mapbox projects

@jfirebaugh
Copy link
Contributor

If we want to benchmark between v0.9.0 or earlier and current master / upcoming v0.10.0, the benchmark tool needs to:

  • load v7 style for v0.9.0 and v8 style for v0.10.0
  • swap coordinate order of center location depending on version

@tmcw
Copy link
Contributor

tmcw commented Sep 3, 2015

Whoops, referenced the wrong issue in my PR

@tmcw tmcw closed this as completed in f1110b8 Sep 3, 2015
@fnicollet
Copy link
Contributor Author

Hello @tmcw ,

Can this issue be re-opened? I don't believe your commit fixes the benchmark issue. I just tried it and the benchmark still crashes.

Thanks,

@tmcw tmcw reopened this Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants