Skip to content
This repository has been archived by the owner on Oct 30, 2021. It is now read-only.

Integer overflow in delta encoding in __get #79

Closed
springmeyer opened this issue Jan 20, 2017 · 2 comments
Closed

Integer overflow in delta encoding in __get #79

springmeyer opened this issue Jan 20, 2017 · 2 comments

Comments

@springmeyer
Copy link
Contributor

springmeyer commented Jan 20, 2017

More poking around carmen with an -fsanitize=undefined binary of carmen-cache has revealed a potential overflow. No idea yet if this is harmless, spurious, or an actual problem.

node ./scripts/carmen-analyze.js tiles/01-ne.country.mbtiles
Analyzing tiles/01-ne.country.mbtiles ...
../src/binding.cpp:122:43: runtime error: unsigned integer overflow: 5498430554125 - 6048152813581 cannot be represented in type 'unsigned long long'
SUMMARY: AddressSanitizer: undefined-behavior ../src/binding.cpp:122:43 in 
{ total: 5126,
  degen: 3407,
  ender: 1719,
  byScore: 
   { '0': 534,
     '1': 279,
     '2': 298,
     '3': 325,
     '4': 431,
     '5': 627,
     '6': 756,
     '7': NaN },
  byRelev: 
   { '0.4': 271,
     '0.6': 0,
     '0.8': 0,
     '1.0': 0,
     '1638.6': NaN,
     '1638.4': NaN,
     '1638.2': NaN,
     '1638.0': NaN,
     '1637.8': NaN,
     '1637.6': NaN,
     '1637.4': NaN,
     '1637.2': NaN,
     '1637.0': NaN } }

at

lastval = lastval - *it;

@springmeyer
Copy link
Contributor Author

same next action as #75 (comment)

@springmeyer
Copy link
Contributor Author

presume this was fixed by #116

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant