Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document start args parameter #41

Open
omus opened this issue Apr 16, 2021 · 2 comments · Fixed by #42
Open

Document start args parameter #41

omus opened this issue Apr 16, 2021 · 2 comments · Fixed by #42

Comments

@omus
Copy link

omus commented Apr 16, 2021

After looking through the code I noticed startArgs:

`${sudo(inputs)} ${minikubeDirectory}/minikube start --vm-driver=${driver(
inputs
)} --kubernetes-version ${inputs.kubernetesVersion} ${inputs.startArgs}`

It would be great if this features was documented as some minikube features like --cni have to be set during minikube start

@manusa
Copy link
Owner

manusa commented Apr 21, 2021

Hi @omus,
There's already documentation about this in the Optional input parameters section.
However, if you missed it, it's probably not in the best place, or missing emphasis.
Do you have any suggestions to improve this?

@omus
Copy link
Author

omus commented Apr 23, 2021

Wow, I'm not sure how I missed that...

I think where it's located in the documentation is fine but I would make minikube start link to https://minikube.sigs.k8s.io/docs/commands/start/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants