Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: use X-Hub-Signature-Sha-256 header to validate webhook payloads #361

Closed
dregad opened this issue Mar 19, 2021 · 0 comments
Closed

GitHub: use X-Hub-Signature-Sha-256 header to validate webhook payloads #361

dregad opened this issue Mar 19, 2021 · 0 comments
Labels
GitHub security
Milestone
2.5.0

Comments

@dregad
Copy link
Member

dregad commented Mar 19, 2021

In late 2020, GitHub introduced a new X-Hub-Signature-Sha-256 header to sign Webhook payloads with the more secure sha256 hash.

The legacy, sha1-based X-Hub-Signature header we're currently using is still around for backwards compatibility, but we should update the precommit() method to use the new one.
@dregad dregad added this to the 2.5.0 milestone Mar 19, 2021
@dregad dregad closed this as completed in a9918a6 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GitHub security
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@dregad