Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab: improve error handling when initializing the Repository ID #352

Closed
dregad opened this issue Jan 17, 2021 · 0 comments
Closed

Gitlab: improve error handling when initializing the Repository ID #352

dregad opened this issue Jan 17, 2021 · 0 comments
Labels
enhancement GitLab
Milestone
2.5.0

Comments

@dregad
Copy link
Member

dregad commented Jan 17, 2021 •
edited
Loading

Currently, a generic Repository Name is invalid message is stored in hub_repoid when the Repository ID could not be retrieved from Gitlab API.

This can be misleading, as there are other error scenarios:

  • Invalid URL or unable to reach server (e.g. network problems)
  • Bad API Key
  • API Key with insufficient privileges
  • Invalid Repo name

The system should provide a more specific error message, and warn the user that something went wrong (currently, an "Operation successful" banner is printed in all cases.
@dregad dregad modified the milestones: 2.4.1, 2.5.0 Jan 17, 2021
@dregad dregad closed this as completed in 2404c1a Jan 23, 2021
dregad added a commit that referenced this issue May 13, 2021
@dregad
Fix system warning on first update of Gitlab repo
def7527 
When the repo is first updated after initial creation, update_repo()
throws a SYSTEM WARNING, as hub_reponame is not yet defined when we
check its value to set $f_hub_repoid.

Issue #352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement GitLab
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@dregad