Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNN query is not logged properly #2804

Open
5 tasks
sanikolaev opened this issue Nov 30, 2024 · 2 comments
Open
5 tasks

KNN query is not logged properly #2804

sanikolaev opened this issue Nov 30, 2024 · 2 comments

Comments

@sanikolaev
Copy link
Collaborator

Bug Description:

mysql> select id, knn_dist() from test where knn ( image_vector, 5, (0.286569,-0.031816,0.066684,0.032926), 2000 );
+------+------------+
| id   | knn_dist() |
+------+------------+
|    1 | 0.28146550 |
|    2 | 0.81527930 |
+------+------------+
2 rows in set (0.00 sec)
--- 2 out of 2 results in 3ms ---

is logged as:

/* Sat Nov 30 18:07:30.935 2024 conn 18169 (127.0.0.1:52399) real 0.003 wall 0.003 found 2 */ SELECT id, knn_dist() FROM test;

i.e. the knn() params get missed.

Manticore Search Version:

Manticore 6.3.9 c96df395d@24112911 dev (columnar 2.3.1 edadc69@24112219) (secondary 2.3.1 edadc69@24112219) (knn 2.3.1 edadc69@24112219)

Operating System Version:

Ubuntu Jammy (dev2)

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@smellbee
Copy link

I suggest using a config parameter to disable log knn float points, coz, there are always high dimensional vectors (768, 1024,1536, etc) which is quite big, which adds obvious overhead

@sanikolaev
Copy link
Collaborator Author

I suggest using a config parameter to disable log knn float points, coz, there are always high dimensional vectors (768, 1024,1536, etc) which is quite big, which adds obvious overhead

There's sphinxql:compat logging mode:

  • which can be adapted to this case
  • should be documented well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants