Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log flag into Buddy protocol #394

Closed
6 tasks done
donhardman opened this issue Nov 12, 2024 · 1 comment
Closed
6 tasks done

Add log flag into Buddy protocol #394

donhardman opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@donhardman
Copy link
Collaborator

donhardman commented Nov 12, 2024

Proposal:

We should add a log boolean flag that will be either true or false to let the daemon know when it needs to log the request and when it doesn't.

As an initial approach, we should set it to true when the original request query is of type SELECT.

Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
  • OpenAPI YAML updated and issue created to rebuild clients
@donhardman
Copy link
Collaborator Author

As discussed today, we may use just total in meta to determine whether we should log or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant