Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search does not work in some cases #373

Closed
5 tasks done
donhardman opened this issue Oct 14, 2024 · 4 comments
Closed
5 tasks done

Fuzzy search does not work in some cases #373

donhardman opened this issue Oct 14, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@donhardman
Copy link
Collaborator

donhardman commented Oct 14, 2024

Bug Description:

MRE:

mysql -h0 -P9306 -e "select id from comment_28798446 WHERE match('buisness Manticore interation') option fuzzy = 1, layouts = ''"
ERROR 1064 (42000) at line 1: unknown option 'fuzzy'

We should investigate and fix it.

Manticore Search Version:

Latest dev version

Operating System Version:

Ubuntu Jammy

Have you tried the latest development version?

None

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@donhardman
Copy link
Collaborator Author

As discussed, we should implement the following defaults:

  • layouts = ru,us,ua for Autocomplete
  • layouts = '' for Fuzzy due to performance issues

@donhardman
Copy link
Collaborator Author

Fix implemented: #376

We should consider adding the following tests:

  1. Fuzzy options + empty layouts did not work before, e.g.,
    SELECT id FROM comment_28798446 WHERE MATCH('business Manticore interaction') OPTION fuzzy = 1, layouts = '';
    SELECT id FROM comment_28798446 WHERE MATCH('business Manticore interaction') OPTION fuzzy = 1, layouts = '';
    
  2. Fuzzy search with "Manticore" in MATCH.

@donhardman
Copy link
Collaborator Author

@PavelShilin89 Please, proceed with adding extra tests to cover it

@PavelShilin89
Copy link

@donhardman Testing performed in PR - manticoresoftware/manticoresearch#2756
I ask for a test review and approval for the merger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants