-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve table formatter approach #369
Comments
Once done let's add CLT tests for these combinations:
|
Implementation finished, but waiting for manticoresoftware/manticoresearch#2680 to be resolved before we can test it in the easiest way possible. |
@Nick-S-2018
If you need to assist with the new way of forming the response, reach me on Slack. The problem is that the test can't find "_id" in the response, which is weird. @PavelShilin89, please proceed with the tests in this branch: manticoresoftware/manticoresearch#2701. Let me know if you need any further information or assistance. |
I found and fixed the issue on my own, so we can proceed with tests |
@donhardman Testing performed in PR - manticoresoftware/manticoresearch#2701 |
Bug Description:
The table version of view for
SHOW VERSION
query gives us JSONcurl http://localhost:9308/cli?show%20version
Due to the underlying architecture we use in Buddy
tableFormatter
, we should consider rethinking our approach and possibly refactor it in a way that allows table representation for each command to be added automatically.Manticore Search Version:
Latest dev version
Operating System Version:
Ubuntu Jammy
Have you tried the latest development version?
None
Internal Checklist:
To be completed by the assignee. Check off tasks that have been completed or are not applicable.
The text was updated successfully, but these errors were encountered: