Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks glimmer template only components #226

Closed
nickschot opened this issue Sep 10, 2018 · 5 comments
Closed

Breaks glimmer template only components #226

nickschot opened this issue Sep 10, 2018 · 5 comments

Comments

@nickschot
Copy link

Template only components are currently broken by ember-css-modules < 1.0.0 . There is a 1.0.0-beta.1 available which fixes this.

See:

@cah-brian-gantzler
Copy link

If I understand correctly, the beta should also fix the following issue

WARNING: /Users/brian.gantzler/source/rxid/ember/ember-rxid/node_modules/ember-css-modules/tests/dummy-addon:
WARNING: Missing package directory

@nickschot
Copy link
Author

nickschot commented Sep 22, 2018

Greenkeeper made a branch for the new stable ember-css-modules: #228

@hoIIer
Copy link

hoIIer commented Feb 17, 2019

@ynnoj @mansona any way we could get this dep updated which will resolve the warning message anyone using this is seeing in their project? thanks! (ps checked out Moltin - seems interesting!)

WARNING:
WARNING: /Users/eric/Dropbox/projects/sqwok/build/client-web/node_modules/ember-css-modules/tests/dummy-addon:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/eric/Dropbox/projects/sqwok/build/client-web/node_modules/ember-css-modules/tests/dummy-less-addon:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/eric/Dropbox/projects/sqwok/build/client-web/node_modules/ember-css-modules/tests/dummy-sass-addon:
WARNING:    Missing package directory
WARNING:
WARNING: /Users/eric/Dropbox/projects/sqwok/build/client-web/node_modules/simple-html-tokenizer/commands:
WARNING:    Missing package directory
WARNING: For addon at path /Users/eric/Dropbox/projects/sqwok/build/client-web/node_modules/ember-css-modules:
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy-addon'
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy-sass-addon'
WARNING:    Excluding invalid/malformed/missing addon at relative path 'tests/dummy-less-addon'
WARNING: An ember-addon has attempted to override the core command "test". The core command will be used.

@mansona
Copy link
Owner

mansona commented Nov 12, 2019

Can anyone try out the new version #251 (comment) and let me know if this is still a problem? 🤔

@mansona
Copy link
Owner

mansona commented Jan 9, 2020

We are no longer using css-modules so this won't be an issue anymore 👍

@mansona mansona closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants