Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Failed import on sphinx 7.3 #255

Closed
j-carson opened this issue Apr 17, 2024 · 6 comments
Closed

Bug: Failed import on sphinx 7.3 #255

j-carson opened this issue Apr 17, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@j-carson
Copy link
Contributor

j-carson commented Apr 17, 2024 •
edited by mansenfranzen
Loading

Sphinx 7.3 stopped exporting py_sig_re

Extension error:
Could not import extension sphinxcontrib.autodoc_pydantic (exception: cannot import name 'py_sig_re' from 'sphinx.domains.python'

Addressed in sphinx-doc/sphinx#12303.
@j-carson
Copy link
Contributor Author

Commit where it disappeared https://github.com/sphinx-doc/sphinx/pull/12297/files

@mansenfranzen mansenfranzen changed the title failed import on sphinx 7.3 Bug: Failed import on sphinx 7.3 Apr 18, 2024
@lwasser
Copy link

lwasser commented Apr 18, 2024 •
edited
Loading

hi! we have the same issue / same error here . our build runs fine on sphinx 7.3.5 so I believe the 7.3.6 released triggered this issue the autodoc_pydantic! Many thanks for all of the work you all are doing on this extension 🙌 i fixed this temporarily but pinning sphinx to 7.3.5 for the time being :)

@mansenfranzen mansenfranzen added the bug Something isn't working label Apr 18, 2024
Repository owner deleted a comment from allcontributors bot Apr 22, 2024
@mansenfranzen
Copy link
Owner

@all-contributors please add @lwasser for bug

@allcontributors allcontributors bot mentioned this issue Apr 22, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@mansenfranzen

I've put up a pull request to add @lwasser! 🎉

@mansenfranzen
Copy link
Owner

Closed by @AA-Turner via sphinx-doc/sphinx#12303

@lwasser
Copy link

lwasser commented Apr 22, 2024

Thank you @mansenfranzen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lwasser @mansenfranzen @j-carson