Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding require-atomic-updates when it becomes more stable #112

Open
manovotny opened this issue Jul 15, 2019 · 3 comments
Open

Comments

@manovotny
Copy link
Owner

manovotny commented Jul 15, 2019

As much as we want to include it, it's just too unstable right now and causes too many false positives right now.

@roboli
Copy link

roboli commented Jul 26, 2019

It won't let me do this for example

`let action;

const withAction = async () => {
  if(!action) {
    action = await actions.getOne({ id });
  }
  return { action };
};`

Do you think is also due the above? Thanks.

@manovotny
Copy link
Owner Author

@roboli yep, that's exactly why I removed it from v5 after beta feedback.

I just released 5.0.0-beta.5, which no longer contains the rule.

@manovotny
Copy link
Owner Author

Updated original message. Two of three issues fixed! Progress, but still holding off on adoption for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants