Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 2023.1.15 where new fragment delimiters can interfere with string templates #474

Closed
rsmckinney opened this issue Aug 17, 2023 · 1 comment
Closed

Regression in 2023.1.15 where new fragment delimiters can interfere with string templates #474

rsmckinney opened this issue Aug 17, 2023 · 1 comment

Comments

@rsmckinney
Copy link
Member

As reported in https://manifold-group.slack.com/archives/C013208SXJQ/p1692287525410089

A string template beginning with a fragment delimiter will not be processed as a string template:

String s = "[${42}]";

Should evaluate as "[42]", but is taken literally because it starts with [, which is the new fragment delimiter.
rsmckinney added a commit that referenced this issue Aug 17, 2023
@rsmckinney
https://github.com/manifold-systems/manifold/issues/474
0af4c35 
- fix regression where new fragment delimiter interfered with string templates, changed processing of string templates to avoid false positive detection of fragments
@rsmckinney
Copy link
Member Author

Fix available with release 2023.1.16

rsmckinney added a commit that referenced this issue Aug 19, 2023
@rsmckinney
https://github.com/manifold-systems/manifold/issues/474
8ebf92d 
- don't support fragment expressions as binary expression operands, particularly combined with string templates, which compiles as concatenation of new string literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rsmckinney