Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fragment delimiters from [> and <] to [ and /] #473

Closed
rsmckinney opened this issue Aug 10, 2023 · 1 comment
Closed

Change fragment delimiters from [> and <] to [ and /] #473

rsmckinney opened this issue Aug 10, 2023 · 1 comment

Comments

@rsmckinney
Copy link
Member

rsmckinney commented Aug 10, 2023

Change fragment delimiters from [> and <] to [ and /].

While writing tests for manifold-sql, where fragments are used a lot, I personally found typing [>Xxx.sql<] to be a pita. Although not quite as unique as the existing delimiters, the proposed delimiters [Xxx.sql/] are easy to type/read and are unique enough to pass the github regex search test. Other delimiters that were considered: [[Xxx.sql]], >>Xxx.sql<<, and some others.

A side note:
Although it is unlikely there will be a string or comment beginning with a full syntax match for a fragment, what if the unlikely happens? The errant comment or string literal would cause a compile error and would have to be changed. Not a big deal. Another option is to make the delimiters configurable. Simple enough to do.

rsmckinney added a commit that referenced this issue Aug 11, 2023
rsmckinney added a commit to manifold-systems/manifold-ij that referenced this issue Aug 11, 2023
rsmckinney added a commit that referenced this issue Aug 11, 2023
- update docs / comments to use new delimiters
@rsmckinney
Copy link
Member Author

Fixed with release 2923.1.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant