You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change fragment delimiters from [> and <] to [ and /].
While writing tests for manifold-sql, where fragments are used a lot, I personally found typing [>Xxx.sql<] to be a pita. Although not quite as unique as the existing delimiters, the proposed delimiters [Xxx.sql/] are easy to type/read and are unique enough to pass the github regex search test. Other delimiters that were considered: [[Xxx.sql]], >>Xxx.sql<<, and some others.
A side note:
Although it is unlikely there will be a string or comment beginning with a full syntax match for a fragment, what if the unlikely happens? The errant comment or string literal would cause a compile error and would have to be changed. Not a big deal. Another option is to make the delimiters configurable. Simple enough to do.
The text was updated successfully, but these errors were encountered:
Change fragment delimiters from
[>
and<]
to[
and/]
.While writing tests for manifold-sql, where fragments are used a lot, I personally found typing
[>Xxx.sql<]
to be a pita. Although not quite as unique as the existing delimiters, the proposed delimiters[Xxx.sql/]
are easy to type/read and are unique enough to pass the github regex search test. Other delimiters that were considered:[[Xxx.sql]]
,>>Xxx.sql<<
, and some others.A side note:
Although it is unlikely there will be a string or comment beginning with a full syntax match for a fragment, what if the unlikely happens? The errant comment or string literal would cause a compile error and would have to be changed. Not a big deal. Another option is to make the delimiters configurable. Simple enough to do.
The text was updated successfully, but these errors were encountered: