Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Uint8Array as GetTypedData parameters #896

Closed
wants to merge 1 commit into from
Closed

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented Nov 22, 2024

  • npm run checks now gives errors because Common.GetTypedData wants STRICT ArrayBuffer as parameter.

  • This appends when

  1. We get picture as ArrayBuffer, create an Uint8Array from it, decrypt the picture using that Uint8Array.
  2. We return Common.GetTypedData(decrypted_Uint8Array)

I.e : NicoNicoSeiga.

Its stupid to convert decrypted_Uint8Array to an ArrayBuffer AGAIN because GetTypedData will convert it to Uint8Array anyway.

@MikeZeDev
Copy link
Contributor Author

Superseded by 07be4b4

@MikeZeDev MikeZeDev closed this Nov 23, 2024
@MikeZeDev MikeZeDev deleted the tschecks branch November 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant