Allow Uint8Array as GetTypedData parameters #896
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run checks now gives errors because
Common.GetTypedData
wants STRICTArrayBuffer
as parameter.This appends when
ArrayBuffer
, create anUint8Array
from it, decrypt the picture using thatUint8Array
.return Common.GetTypedData(decrypted_Uint8Array)
I.e : NicoNicoSeiga.
Its stupid to convert
decrypted_Uint8Array
to an ArrayBuffer AGAIN becauseGetTypedData
will convert it toUint8Array
anyway.