Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisasterScans: website changes #893

Merged
merged 1 commit into from
Nov 23, 2024
Merged

DisasterScans: website changes #893

merged 1 commit into from
Nov 23, 2024

Conversation

MikeZeDev
Copy link
Contributor

You cant fetch chapters from CSS since its paginated from Next JSON data on the same page

You cant fetch chapters from CSS since its paginated from Next JSON data on the same page
@Sheepux Sheepux requested a review from Copilot November 22, 2024 13:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

web/src/engine/websites/DisasterScans.ts:56

  • The JSON parsing logic is potentially unsafe and could lead to runtime errors if the script content does not match the expected format. Consider using a more robust method to parse the JSON content.
const content = JSON.parse(script.substring(script.indexOf(',"') + 1, script.length - 2)) as string;
@MikeZeDev MikeZeDev merged commit 0afb1dd into master Nov 23, 2024
5 checks passed
@MikeZeDev MikeZeDev deleted the disaster branch November 23, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants