-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vverbose don't show author in output #993
Comments
I am happy to work on this. is this still open? |
that would be great! please make an attempt and open a PR for review and merge |
Thanks, consider me a beginner. The usage is not really clear to me. I installed the developer version in my venv and I am able to import capa inside my venv. Can you give me an example code with an input elf file that I can use for this PR? Thanks. |
you should be able to test with any PE or ELF file by running |
When I tried to run I got the following error
I found similar error when I tried it on some elf files in |
:( please see related issue: mandiant/capa-rules#551 |
Are you still encountering this error with current master? Anything we can help you with to get started? |
Thanks, it works now. To fix the issue here, is it about removing line |
yeah, kinda, you can take https://github.com/mandiant/capa/pull/973/files as a good example |
I have a question about the PR process. After committing the changes locally, when I run
The tests clearly pass but I don't see any updates on the forked repo. |
You should be able to create a PR on GitHub now for your branch. |
Do you get any output on the command line? |
@pradkrish can you submit your PR or share your changes? Would love to get this in soon. |
@mr-tz That is the problem. After the push operation, I do not see it when I checked on my forked repo for the pushed branch. This is despite passing tests. Anyways, the only change I have done is to remove the line |
Can you double-check to commit and/or push with the |
analogous to #973, remove author as not really helpful when inspecting rules
The text was updated successfully, but these errors were encountered: