Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: add package declaration #1960

Closed
williballenthin opened this issue Jan 31, 2024 · 1 comment · Fixed by #1962
Closed

proto: add package declaration #1960

williballenthin opened this issue Jan 31, 2024 · 1 comment · Fixed by #1962
Labels
breaking-change introduces a breaking change that should be released in a major version
Milestone
v7.0

Comments

@williballenthin
Copy link
Collaborator

we should be using a package statement at the top of our proto files to avoid issues in generated code related to file collisions.

https://buf.build/docs/reference/protobuf-files-and-packages#imports
@williballenthin williballenthin added the breaking-change introduces a breaking change that should be released in a major version label Jan 31, 2024
@williballenthin williballenthin added this to the v7.0 milestone Jan 31, 2024
@williballenthin williballenthin mentioned this issue Jan 31, 2024
Merged
18 tasks
@mr-tz
Copy link
Collaborator

mr-tz commented Jan 31, 2024 •
edited
Loading

also setup the linter: https://buf.build/docs/ci-cd/github-actions#buf-setup
edit: scratch that, unrelated/unneded

This was referenced Jan 31, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change introduces a breaking change that should be released in a major version
Projects
None yet
Milestone
v7.0
Development

Successfully merging a pull request may close this issue.

Add package name for proto mandiant/capa
Add package name for CAPA proto larchchen/capa
2 participants
@williballenthin @mr-tz