Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted (colored) text hard to read in cmd.exe (and other terminals?) #1384

Closed
mr-tz opened this issue Mar 15, 2023 · 7 comments · Fixed by #1399
Closed

Highlighted (colored) text hard to read in cmd.exe (and other terminals?) #1384

mr-tz opened this issue Mar 15, 2023 · 7 comments · Fixed by #1399
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 15, 2023

Change the colors/highlights so that output is clearly visible on black, dark, light, and white backgrounds. Use "cyan" instead of "blue", with the rational described in mandiant/flare-floss#659.

The blue can be hard to read, green appears ok:
2023-03-15_10-17-25_cmd

2023-03-15_10-18-36_cmd

@mr-tz mr-tz added the enhancement New feature or request label Mar 15, 2023
@ggold7046
Copy link
Contributor

I would like to work on it...... could you guide me ? What file do I need to dig in ?

@williballenthin

This comment was marked as outdated.

@ggold7046

This comment was marked as outdated.

@williballenthin
Copy link
Collaborator

mandiant/flare-floss#655 is closed now via mandiant/flare-floss#659

you're welcome to port the color theme changes to capa. please continue to use the styling library in capa (colorama and termcolor), we're not prepared to migrate to rich yet. still, it should be possible to update just the colors pretty easily.

@williballenthin
Copy link
Collaborator

Btw could you please point me to the file section, so that I could have a look at the code ?

I don't quite understand your question here. What do you mean by "file section"?

@williballenthin williballenthin added the good first issue Good for newcomers label Mar 23, 2023
@ggold7046
Copy link
Contributor

Btw could you please point me to the file section, so that I could have a look at the code ?

I don't quite understand your question here. What do you mean by "file section"?

Actually I was trying to figure out the files that will be using the styling library.

@williballenthin
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants