Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loop detection: branch target may be None (for dynamic calls) #1310

Closed
mr-tz opened this issue Feb 11, 2023 · 0 comments · Fixed by #1317
Closed

loop detection: branch target may be None (for dynamic calls) #1310

mr-tz opened this issue Feb 11, 2023 · 0 comments · Fixed by #1317
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Feb 11, 2023

see similar issue in mandiant/flare-floss#627

capa/capa/features/extractors/viv/function.py

Lines 49 to 56 in ad47ea3

for bva, bflags in bb.instructions[-1].getBranches():
# vivisect does not set branch flags for non-conditional jmp so add explicit check
if (
bflags & envi.BR_COND
or bflags & envi.BR_FALL
or bflags & envi.BR_TABLE
or bb.instructions[-1].mnem == "jmp"
):

@mr-tz mr-tz added the bug Something isn't working label Feb 11, 2023
@williballenthin williballenthin added the good first issue Good for newcomers label Feb 12, 2023
@mr-tz mr-tz mentioned this issue Feb 15, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix loop detection corner case mandiant/capa
2 participants
@williballenthin @mr-tz