move API name normalization to helper function

mandiant · Apr 6, 2022 · 834d751 · 834d751
1 parent 6947497
commit 834d751
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/capa/features/extractors/helpers.py b/capa/features/extractors/helpers.py
@@ -52,6 +52,9 @@ def generate_symbols(dll: str, symbol: str) -> Iterator[str]:
       - CreateFileA
       - CreateFile
     """
+    # normalize dll name
+    dll = dll.lower()
+
     # kernel32.CreateFileA
     yield "%s.%s" % (dll, symbol)
 

diff --git a/capa/features/insn.py b/capa/features/insn.py
@@ -12,14 +12,10 @@
 
 class API(Feature):
     def __init__(self, name: str, description=None):
-        # Downcase library name if given
-        if "." in name:
-            modname, _, impname = name.rpartition(".")
-            name = modname.lower() + "." + impname
-
         super(API, self).__init__(name, description=description)
 
 
+
 class Number(Feature):
     def __init__(self, value: int, bitness=None, description=None):
         super(Number, self).__init__(value, bitness=bitness, description=description)