Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating correct on cmd #43

Closed
wants to merge 2 commits into from
Closed

Activating correct on cmd #43

wants to merge 2 commits into from

Conversation

tdegeus
Copy link
Contributor

@tdegeus tdegeus commented Mar 4, 2022

Fixes #39

@tdegeus
Copy link
Contributor Author

tdegeus commented Mar 4, 2022

What is a bit funny though is that NumPy does seem to be found

@jonashaag
Copy link
Contributor

Does it make sense to merge this test with some of the existing ones?

@tdegeus
Copy link
Contributor Author

tdegeus commented Mar 4, 2022

I would have thought that this test is completely unnecessary as I was thinking that https://github.com/mamba-org/provision-with-micromamba/blob/main/.github/workflows/test.yml did the job. Turns out however that something is going wrong

@jonashaag
Copy link
Contributor

@tdegeus what's the status of this PR?

@tdegeus
Copy link
Contributor Author

tdegeus commented May 13, 2022

@jonashaag I'm pretty sure this should work, but doesn't. I briefly looked at the Action, but I lacked the time/expertise to come up with a fix.

As I said before, I would have thought that the existing CI would have picked up on this, but that all passes. So: no real clue what is going on

@jonashaag
Copy link
Contributor

OK, looks like the Autorun code isn't executed.

@jonashaag
Copy link
Contributor

Actually this is covered by our tests and fails in the tests as well but the failure is ignored.

@jonashaag jonashaag closed this May 13, 2022
@tdegeus
Copy link
Contributor Author

tdegeus commented May 13, 2022

Thanks for investigating @jonashaag . So it is a bug that needs solving?

@jonashaag
Copy link
Contributor

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working out of the box with cmd
2 participants