Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d.ts not updated #133

Closed
eyal1990 opened this issue Mar 1, 2017 · 5 comments
Closed

d.ts not updated #133

eyal1990 opened this issue Mar 1, 2017 · 5 comments

Comments

@eyal1990
Copy link

eyal1990 commented Mar 1, 2017

The d.ts of the project is not updated.
The main problem is the inclusion of this line:

import React = __React;

When using @types/react there is no global variable named __React and so this file breaks the build.
The solution is kind of easy - omit the d.ts file from the project.
This way, whoever wants to use the d.ts will use @types/react-custom-scrollbars which don't use the global __React variable.

(In a way, inserting the d.ts was a breaking change for everyone who used @types/react).

Let me know what you think.

@aalenliang
Copy link
Contributor

+1 the .d.ts file in project breaks usage.

@malte-wessel
Copy link
Owner

I'm not quite familiar with TypeScript, would be cool if someone made a PR to fix this!

@aalenliang
Copy link
Contributor

  1. remove the index.d.ts file,
  2. and delete
    "typings": "index.d.ts",
    section in package.json.

@aalenliang
Copy link
Contributor

#135

@malte-wessel
Copy link
Owner

Fixed by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants