Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Circle map. #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds Circle map. #62

wants to merge 2 commits into from

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Jan 9, 2024

🎉 New feature

Closes #61

Summary

image

  • A circle map is added
  • The map is created using two OpenDRIVE roads
    • Each road is half of the circle
    • This allows to linkage to be filled correctly:
      • Road 0 is the predecessor and successor of Road 1
      • Road 1 is the predecessor and successor of Road 0
      • Note that with only one road, it can't be done()

Check #64 as this PR is modified by that one.

Test it!

Check the readme:

WIDTH=3.5 RADIUS=6.5 empy3 templates/circle.xml.em > generated_file.xodr

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <[email protected]>
@liangfok
Copy link
Contributor

Thanks for creating this map. We need to modify it slightly: #61 (comment)

liangfok pushed a commit that referenced this pull request Jan 16, 2024
Still need to modify docs/circle.png.

Relates to #61 and #62.
liangfok pushed a commit that referenced this pull request Jan 16, 2024
Still need to update docs/circle.png.

Relates to #61 and #62.
liangfok pushed a commit that referenced this pull request Jan 16, 2024
Still need to update docs/circle.png.

Relates to #61 and #62.


Signed-off-by: Liang Fok <[email protected]>
@agalbachicar agalbachicar mentioned this pull request Jan 26, 2024
5 tasks
* Updates the circle template:

- Adds inner and outer lane width parameter.
- Splits the roundabout into 4 roads instead of 2.
- Updates the readme accordingly.

---------

Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Franco Cipollone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map Request: Circle with 6.5m inner radius and two 3.5m wide lanes
3 participants