CI: Update path to repositories when using actions/checkout action

[francocipollone]

This targets all the repos in the maliput ecosystem

Summary

We are using

    - uses: actions/checkout@v2
      with:
        repository: ToyotaResearchInstitute/maliput
        fetch-depth: 0
        path: ${{ env.ROS_WS }}/src/maliput
        token: ${{ secrets.MALIPUT_TOKEN }}

for each dependency.

Let's use maliput/maliput instead of ToyotaResearchInstitute/maliput

Alternative

We could directly handle it via dependencies.repos file and remove all the actions/checkout actions making the workflow a bit simpler.

[francocipollone]

We could directly handle it via dependencies.repos file and remove all the actions/checkout actions making the workflow a bit simpler.

Wdyt? @agalbachicar

[agalbachicar]

Is this OK?

Let's use ToyotaResearchInstitute/maliput instead of maliput/maliput

I think you wanted to say the other way around, right?

[agalbachicar]

I would like us to explore https://github.com/ros-tooling/action-ros-ci for this. It is the standard way AFAIK. We can shrink considerably our action files and avoid duplication. The only problem I see with it is that the branching scheme is not possible with a repos file.

[agalbachicar]

@francocipollone what do you think about suggesting to merge the try_vcs_checkout flow within action-ros-ci in a ticket?

[francocipollone]

The only problem I see with it is that the branching scheme is not possible with a repos file.

And skipping keys for the rosdep install (We are using it for pybind11) ros-tooling/action-ros-ci#276

what do you think about suggesting to merge the try_vcs_checkout flow within action-ros-ci in a ticket?

There is a similar request here ros-tooling/action-ros-ci#157
And they are already providing some kind of support for multi-repo development:

• Not merged PR: Support declaring PR dependencies in PR description ros-tooling/action-ros-ci#490
• Merged PR: Support overriding repos files & providing supplemental ones in PRs ros-tooling/action-ros-ci#524 .
  Which is great, but it isn't exactly what we would like. We could adapt tho I think.

Therefore, I don't think that this script would be accepted as they are already providing something similar using a different "API".

---

Once skip-keys is added, ros-action-ci could be used for at least one of the workflows we have. Not for the sanitizers and scan-build related workflows.

[agalbachicar]

Probably, it is worth another ticket, we should look into colcon mixins for sanitizers.

• https://github.com/colcon/colcon-mixin-repository/
• https://colcon.readthedocs.io/en/released/reference/mixin-arguments.html

I think we will simplify workflows and standardize behavior to what other packages are doing.