-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger sanitizers workflow if label is added #37
Conversation
Check for the do-clang-test label in order to trigger the sanitizer workflow.
ok, it hasn't triggered the sanitizer tests just by opening the pull request; I'll now apply the label... |
ok, it just triggered a bunch of new builds |
after they finish, I'll try adding an additional commit to see if the jobs keep triggering |
looks like the tsan build failed |
Having tsan for maliput_dragway is a bug. It is not prepared for it and we don't have any concurrent code to evaluate. Would you please remove it? BTW the feature looks amazing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
disabled tsan in e8157f6 I also disabled the builds for pushes to master branch
:) |
no clang builds were triggered for my most recent commit, which is what I expected, since I expect it to only trigger a build when a label is added I'm going to try adding a different label. I expect that it will trigger a build, since the logic currently checks for the presence of the |
adding the it looks like I didn't fully disable |
What if we just remove and add again the same label? |
I just tested that as well and that works. The point of this test was to confirm that the logic is currently not checking the content of the new label, just the content of all current labels. I think it would be a little nicer to check the newly added label, but I'm not sure exactly how to do that. I think it's pretty good like this though. Let me know if that didn't make sense |
Let's move forward with this as is. I can help to deploy this in all repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks! |
Check for the
do-clang-test
label in order to trigger the sanitizer workflow.Part of maliput/maliput_infrastructure#177