Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses namespaces in cmake targets. #19

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Uses namespaces in cmake targets. #19

merged 3 commits into from
Nov 24, 2020

Conversation

agalbachicar
Copy link
Collaborator

Relates to maliput/maliput_infrastructure#146

  • Uses "maliput_dragway::" for targets.
  • Uses "maliput_dragway_" for library file name prefix.

@agalbachicar
Uses namespaces in cmake targets.
348bd75 
- Uses "maliput_dragway::" for targets.
- Uses "maliput_dragway_" for library file name prefix.
@agalbachicar
Reverts dragway python binding library name.
ffbc910
@agalbachicar agalbachicar marked this pull request as ready for review November 24, 2020 15:05
@scpeters
Copy link
Contributor

sorry for the conflicts

francocipollone
francocipollone previously approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@agalbachicar agalbachicar merged commit 2469914 into master Nov 24, 2020
@agalbachicar agalbachicar deleted the agalbachicar/use_namespaces branch November 24, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francocipollone francocipollone francocipollone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agalbachicar @scpeters @francocipollone