Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopicViewer doesn't introspect custom protobuf messages #359

Closed
caguero opened this issue Apr 11, 2018 · 1 comment
Closed

TopicViewer doesn't introspect custom protobuf messages #359

caguero opened this issue Apr 11, 2018 · 1 comment

Comments

@caguero
Copy link
Contributor

caguero commented Apr 11, 2018

The main reason for this issue is the inability to receive an unknown serialized protobuf message and unserialize it into a generic protobuf message. Protobuf requires to cast the message into a specific type and this type is not known by Ignition Transport from the TopicViewer.

An alternative solution might be to generate our custom messages with descriptor information (--descriptor_set_out) and use DynamicMessage to manipulate the message at runtime. Another solution might be to specify the path of the proto files at runtime and check if there are Protobuf utilities to generate a message on the fly based on the proto messages found.

There's some research to do here.

@caguero caguero added this to the Milestone #3 milestone Apr 11, 2018
@caguero caguero self-assigned this Apr 11, 2018
@caguero
Copy link
Contributor Author

caguero commented May 1, 2018

Here's a first implementation in Ignition Msgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant