Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for arm64_32 architecture in Xcode 10 for Carthage #594

Closed
WillAnd31 opened this issue Sep 20, 2018 · 1 comment
Closed

Support for arm64_32 architecture in Xcode 10 for Carthage #594

WillAnd31 opened this issue Sep 20, 2018 · 1 comment
Assignees
@malcommac
Labels
duplicate enhancement
Milestone
5.0.10

Comments

@WillAnd31
Copy link

Building SwiftDate using Carthage fails because in SwiftDate/Supports/Commons.swift the method combineHashValues doesn't account for the architecture type: arm64_32 which seems to have been added in Xcode 10.

RxSwift ran into this same problem and this is how they fixed it:
https://github.com/ReactiveX/RxSwift/pull/1740/files
@WillAnd31 WillAnd31 mentioned this issue Sep 20, 2018
Merged
@malcommac malcommac added this to the 5.0.10 milestone Oct 9, 2018
@malcommac malcommac self-assigned this Oct 9, 2018
@malcommac
Copy link
Owner

Added in #595 thanks

@malcommac malcommac changed the title Support for arm64_32 architecture in Xcode 10 Support for arm64_32 architecture in Xcode 10 for Carthage Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
duplicate enhancement
Projects
None yet
Milestone
5.0.10
Development

No branches or pull requests
2 participants
@malcommac @WillAnd31