Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove testsuite-generated from source control #227

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

marler8997
Copy link
Contributor

Builds wast2json using the upstream WebAssembly source and some build.zig and uses that to generate the testsuite json files on demand.

Tested on macOS/Windows and linux.

Builds wast2json using the upstream WebAssembly source and some
build.zig and uses that to generate the testsuite json files on demand.
@malcolmstill
Copy link
Owner

@marler8997 this is great, love the approach of building wast2json from source (which nicely solves why I added the blobs in the first place, which if I recall correctly was to avoid depending on the tools via apt get).

@malcolmstill
Copy link
Owner

Also I've changed the repo settings so the CI should kick in now automatically if you make a PR

@marler8997
Copy link
Contributor Author

marler8997 commented Jun 15, 2024

Looks like the parsecheck step/tool were validating the wasm binaries commited to the repo that were the output of wast2json? If so, we could probably remove this step/tool since the testsuite itself would validate the output correct?

This was validating the WASM binaries that were commited to source control
and generated by the wast2json tool.  These files were removed and are
now generated and then immediately tested on the fly.
@malcolmstill
Copy link
Owner

@marler8997 I'm trying to understand why parsecheck was added in the first place; from #168 looks like it was maybe for testing that parsing never crashes (even for features that were yet to be supported) and I also see that it I was saving .wasm blobs that I had generated through fuzz testing that had highlighted bugs in the parser.

I'll have a think about that latter point (of the fuzzed examples) and maybe you can let me know your thoughts, but I'm happy to just remove this code for the moment (it's a trivial amount of code)

@malcolmstill malcolmstill merged commit bcb64e0 into malcolmstill:master Jun 15, 2024
16 checks passed
@marler8997 marler8997 deleted the wast2json branch June 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants