separate module decoding state/methods into their own struct #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove fixed buffer stream from Module and all the decode/read functions and move then into a separate Decoder struct so they can be discarded after decoding is complete * removed version field from Module (unused) * combined common code between min/max limit cases * rename `module` field to `wasm_bin` on Module struct to distinguish the wasm binary buffer from the higher level module object * fixed `readSlice` so it doesn't call skipBytes which unnecessarily copies the entire slice and throws it away * add .zig-cache to .gitignore for zig 0.13.0
|
Thanks for this @marler8997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the state (fixed buffer stream) and methods (decode/read) around decoding a module into a separate struct
Decoderso they can be discarded after the module is decoded.Along with this change, I also fixed a few more things I noticed along the way:
modulefield towasm_binon Module struct to distinguish the wasm binary buffer from the higher level module objectreadSliceso it doesn't call skipBytes which unnecessarilycopies the entire slice and throws it away