From 5aa8647c7fc482dc0a7b018779a689027104caf5 Mon Sep 17 00:00:00 2001 From: Nazzareno Massari Date: Mon, 13 Feb 2023 17:17:21 +0000 Subject: [PATCH] Cleanups & Refinements --- spell/spell-crafter-goerli-workflow.md | 7 +------ spell/spell-crafter-mainnet-workflow.md | 7 +------ spell/spell-reviewer-goerli-checklist.md | 4 ---- spell/spell-reviewer-mainnet-checklist.md | 4 ---- 4 files changed, 2 insertions(+), 20 deletions(-) diff --git a/spell/spell-crafter-goerli-workflow.md b/spell/spell-crafter-goerli-workflow.md index 111749e5..0a1a2cef 100644 --- a/spell/spell-crafter-goerli-workflow.md +++ b/spell/spell-crafter-goerli-workflow.md @@ -17,8 +17,6 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO * [ ] Check previous spells in the `archive` folder for cleanup patterns * [ ] Cleanup `src/test/config.sol` * [ ] Set `deployed_spell` to `address(0)` - * [ ] Set `deployed_spell_created` to `0` - * [ ] Set `deployed_spell_block` to `0` * [ ] Cleanup Specific Tests in `DssSpell.t.sol` * [ ] Check previous spells in the `archive` folder for cleanup patterns * [ ] Disable specific tests IF Not Used (e.g. `testCollateralIntegrations`, `testNewChainlogValues`, `testNewIlkRegistryValues`, ...) @@ -118,11 +116,8 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO * [ ] `seth chain` * [ ] Deploy spell on Goerli via `make deploy` * [ ] Ensure spell is verified on etherscan -* [ ] Add deployed spell address, timestamp and block number to `config.sol` +* [ ] Add deployed spell address to `config.sol` * [ ] `deployed_spell: address()` - * [ ] `deployed_spell_created: ` - * [ ] `deployed_spell_block: ` - * [ ] Run `make deploy-info tx=` to get timestamp and block number * [ ] Run Tests Locally with deployed spell address * [ ] Commit & Push for Review * [ ] Wait for CI to PASS diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index 6844dfcc..ff33e445 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -17,8 +17,6 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Check previous spells in the `archive` folder for cleanup patterns * [ ] Cleanup `src/test/config.sol` * [ ] Set `deployed_spell` to `address(0)` - * [ ] Set `deployed_spell_created` to `0` - * [ ] Set `deployed_spell_block` to `0` * [ ] Consider to add `previous_spell` address if it haven't been executed yet * [ ] Cleanup Specific Tests in `DssSpell.t.sol` * [ ] Check previous spells in the `archive` folder for cleanup patterns @@ -128,11 +126,8 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] `seth chain` * [ ] Deploy spell on Goerli via `make deploy` * [ ] Ensure spell is verified on etherscan -* [ ] Add deployed spell address, timestamp and block number to `config.sol` +* [ ] Add deployed spell address to `config.sol` * [ ] `deployed_spell: address()` - * [ ] `deployed_spell_created: ` - * [ ] `deployed_spell_block: ` - * [ ] Run `make deploy-info tx=` to get timestamp and block number * [ ] Run Tests Locally with deployed spell address * [ ] Commit & Push for Review * [ ] Wait for CI to PASS diff --git a/spell/spell-reviewer-goerli-checklist.md b/spell/spell-reviewer-goerli-checklist.md index 7699dff5..33d40501 100644 --- a/spell/spell-reviewer-goerli-checklist.md +++ b/spell/spell-reviewer-goerli-checklist.md @@ -143,10 +143,6 @@ Spell Actions: * [ ] Other Settings: default evmVersion, GNU AGPLv3 license * [ ] Deployed Spell Code matches GitHub * [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`) -* [ ] Deploy Timestamp & Block Number Match - * [ ] Ensure `make deploy-info tx=` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol) - * [ ] `deployed_spell_created` timestamp - * [ ] `deployed_spell_block` block number * [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest) * [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit * [ ] Local Tests and CI PASS diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index 33bc9733..62995003 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -147,10 +147,6 @@ Spell Actions: * [ ] Other Settings: default evmVersion, GNU AGPLv3 license * [ ] Deployed Spell Code matches GitHub * [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`) -* [ ] Deploy Timestamp & Block Number Match - * [ ] Ensure `make deploy-info tx=` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol) - * [ ] `deployed_spell_created` timestamp - * [ ] `deployed_spell_block` block number * [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest) * [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit * [ ] Local Tests and CI PASS