Added prompt for test coverage section to ensure compliance

makerdao · Aug 10, 2023 · e031a54 · e031a54
1 parent 38343c2
commit e031a54
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/spell/spell-reviewer-goerli-checklist.md b/spell/spell-reviewer-goerli-checklist.md
@@ -196,7 +196,8 @@ Spell Actions:
   * [ ] Where addresses are fetched from the `ChainLog`, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), except where the archive pattern differs from this pattern (e.g. MKR)
 * [ ] Spell actions match [GovAlpha Spell Content Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)
 * [ ] Local Tests PASS
-  * [ ] Ensure Good Coverage
+  * [ ] Ensure each action has sufficient test coverage
+  _List actions for which coverage was checked here_
   * [ ] Ensure every test function is declared as public if enabled or private if disabled
 
 _Insert your passing local tests here_

diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md
@@ -232,7 +232,8 @@ Spell Actions:
   * [ ] Where addresses are fetched from the `ChainLog`, the variable name must match the value of the ChainLog key for that address (e.g. `MCD_VAT` rather than `vat`), except where the archive pattern differs from this pattern (e.g. MKR)
 * [ ] Spell actions match [GovAlpha Spell Content Sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw) and hashed exec doc (Exec Doc is the source of truth)
 * [ ] Local Tests PASS
-  * [ ] Ensure Good Coverage
+  * [ ] Ensure each action has sufficient test coverage
+  _List actions for which coverage was checked here_
   * [ ] Ensure every test function is declared as public if enabled or private if disabled
 
 _Insert your passing local tests here_