From acdeee31d92f84fbbcd309aaf58cf6775cff8530 Mon Sep 17 00:00:00 2001 From: SidestreamColdMelon Date: Thu, 21 Nov 2024 18:00:20 +0100 Subject: [PATCH] more specific requirement about logs --- spell/spell-crafter-mainnet-workflow.md | 4 ++-- spell/spell-reviewer-mainnet-checklist.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index d17b2a9..a98b104 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -39,7 +39,7 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Insert the release URL here: * [ ] Install the specified version via `foundryup --version git_tag_name` ``` - Document the relevant installation logs below + Document the installation logs containing installed versions below: ``` * Create new branch * [ ] Pull `master` branch of the `spells-mainnet` repo locally @@ -217,7 +217,7 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Commit & push changes for review * [ ] Wait for CI to PASS * [ ] Post a comment inside the PR containing: - * Relevant Foundry installation logs (from above or via `foundryup --version`) + * Foundry installation logs containing installed versions (from above) * A link to the deployed spell * A link to the created Tenderly Testnet * [ ] Notify the reviewers (e.g. "the spell was deployed") diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index bc8aa82..2d539f5 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -7,7 +7,7 @@ * [ ] Insert the release URL here: * [ ] Install the specified version via `foundryup --version git_tag_name` ``` - Document the relevant installation logs below + Document the installation logs containing installed versions below: ``` * Preparation * [ ] Exec Sheet for the specified date is found in the ["Executive Vote Implementation Process" google sheet](https://docs.google.com/spreadsheets/d/1w_z5WpqxzwreCcaveB2Ye1PP5B8QAHDglzyxKHG3CHw)