diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index 64d82f4..bd184bc 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -129,7 +129,7 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Ensure good coverage (every spell action is tested) * [ ] Ensure every test function is declared as `public` * [ ] IF the test needs to run, it MUST NOT have the `skipped` modifier; OTHERWISE, it MUST have the `skipped` modifier - * Testing of modules initialised via the spell + * IF a new module is initialized via the spell, the tests must include * [ ] Sanity checks of the constructor arguments * [ ] Sanity checks of all values added/updated by the spell function * [ ] End-to-end "happy path" interaction with the module diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index 63d8f65..2b9f472 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -314,7 +314,7 @@ * [ ] Ensure each spell action has sufficient test coverage _List actions for which coverage was checked here_ * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`) - * Testing of modules initialised via the spell + * IF a new module is initialized via the spell, the tests must include * [ ] Sanity checks of the constructor arguments * [ ] Sanity checks of all values added/updated by the spell function * [ ] End-to-end "happy path" interaction with the module