This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Collateral Type (e.g.
ETH-A
): UNIV2LPCOB Team Name or Author(s): @hexonaut @lucas-manuel
GemJoin Adapter: GemJoin
Is this GemJoin adapter new? : No
If so, why is a new one needed? : N/A
Contribution Checklist
src/tokens/
asTOKEN.sol
, if not already presentGemJoin
has been added insrc/
asjoin-X.sol
testGemJoinX_TOKEN()
) has been added tosrc/join.t.sol
and follows previous tests as examplesGemJoin
:testFailGemJoinXJoinWad()
testFailGemJoinXExitWad()
testFailGemJoinXJoin()
testFailGemJoinXExit()
testFailJoinAfterCageGemJoinX()
GemJoin
additionChecklist
GemJoin
is added, ensure the above description is accurateGemJoin
is added, ensure a newGemJoin
has been added with the correct namesrc/join.t.sol
to confirm they all pass