Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple monitoring configuration from it's structure #1

Open
makarchuk opened this issue Jun 9, 2019 · 1 comment
Open

Decouple monitoring configuration from it's structure #1

makarchuk opened this issue Jun 9, 2019 · 1 comment

Comments

@makarchuk
Copy link
Owner

I need to separate monitoring configuration from it's actual internal structure.

Sounds very much like a trait to me, with configuration as related type. and method (new?) accepting a value of that type.
makarchuk added a commit that referenced this issue Jun 13, 2019
@makarchuk
Basic outline for monitoring trait (#1)
5e7cf6e 
Will try and implement the same mechanics for other monitorings, to test
usability
@makarchuk
Copy link
Owner Author

While implementing a trait it seems that config should not be an associated type after all
I think IntoMonitoring trait or something like that will be more reasonable to store all creation information in configuration objects (effectively making them a factories).

As for a global configuration I'm considering either enum with all possible configuration types or a registry, which will allow (non-existent) users their own monitorings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@makarchuk