Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If logo is white for transparent header, then you can't see it on login page #524

Open
JiveDig opened this issue Oct 25, 2021 · 6 comments
Labels
question Further information is requested

Comments

@JiveDig
Copy link
Contributor

JiveDig commented Oct 25, 2021

Should we check if transparent header, and scroll logo, then use the scroll logo? Any other ideas here?

@JiveDig JiveDig added the question Further information is requested label Oct 25, 2021
@skydogtech
Copy link

skydogtech commented Oct 25, 2021 via email

@JiveDig
Copy link
Contributor Author

JiveDig commented Oct 25, 2021

Screenshot on 2021-10-25 at 12-25-27

Screenshot on 2021-10-25 at 12-24-33

@JiveDig
Copy link
Contributor Author

JiveDig commented Oct 25, 2021

The only time it would get weird is when the transparent header logo isn't actually white or if the scroll logo is something only for effect, like an icon or something. We don't really know what is what.

Another option is a dedicated Login page logo field.

@shay328
Copy link

shay328 commented Oct 25, 2021

I've seen this. How about if transparent header is enabled, it could use the site-title on the login page instead

@skydogtech
Copy link

skydogtech commented Oct 25, 2021 via email

@JiveDig
Copy link
Contributor Author

JiveDig commented Oct 25, 2021

The site header background color settings is already used on the login page too, so there are a lot of variables in place. I'll have to think about it as the discussion continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants