Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate RefMarker logic to more accurate #888

Open
aslakknutsen opened this issue Sep 3, 2021 · 0 comments
Open

Evaluate RefMarker logic to more accurate #888

aslakknutsen opened this issue Sep 3, 2021 · 0 comments
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement

Comments

@aslakknutsen
Copy link
Member

What can be improved

Currently the Modifiers will mark the changed resources with a hash value to know if we're about to apply the same logic or not.

In all cases this is based on the Hash of the Ref from the Session object. However, modifiers like DestinationRule rely on more information, e.g. the version label from the target Deployment, that won't be reflected in the marker.

Why

Evaluate if each marker should capture the more fine grained and correct information about it's inputs to more precisely detect a change.

@aslakknutsen aslakknutsen added kind/enhancement Kind: New feature or improvement component/operator Component: Operator service labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operator Component: Operator service kind/enhancement Kind: New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant