Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior on machine settings inputs #551

Closed
r3Fuze opened this issue Jan 19, 2022 · 5 comments · Fixed by #555
Closed

Weird behavior on machine settings inputs #551

r3Fuze opened this issue Jan 19, 2022 · 5 comments · Fixed by #555
Assignees
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready ⚡ Type: Bug Something isn't working

Comments

@r3Fuze
Copy link
Contributor

r3Fuze commented Jan 19, 2022

A few weird and confusing things I've noticed with the inputs in the Machine Settings panel:

  • Manually inputting an integer in an input and then pressing the increase arrow to the right adds the step value of the input to the entered integer, for example putting 300 in the input and pressing the up arrow changes the value to 3005. This happens on all inputs that use whole numbers.

  • Manually inputting a float in an input that accepts it and then pressing the up arrow completely erases the value in the input. Inputting an integer works as above.

  • Inputting a value in an input and then unfocusing the input without pressing enter does not make it clear that you haven't actually changed the setting unless you look at the console output.

  • The pressure advance input is limited to 1 even though the advance value can be above 1 in Klipper.

I thought some of these problems were caused by #537 but they were also broken on the commit before the PR was merged.

@lixxbox lixxbox added Prio: 2 Medium Is: UI/UX Anything referencing UI/UX ⚡ Type: Bug Something isn't working 🚦 Status: 1 - Ready labels Jan 19, 2022
@dw-0
Copy link
Member

dw-0 commented Jan 19, 2022

I was able to reproduce point 1 and 2. That is indeed not an intended behavior and has to be fixed. Thanks for pointing that out.

Inputting a value in an input and then unfocusing the input without pressing enter does not make it clear that you haven't actually changed the setting unless you look at the console output.

That is currently the intended behavior. Manual input has to be confirmed by pressing enter. Where the arrows directly send the command.

The pressure advance input is limited to 1 even though the advance value can be above 1 in Klipper.

That is correct. Also the smooth time input field has an upper limit of 0.2
Do you have a valid reason why the upper limits should be removed? A possibly required pressure advance value greater than 1 is an indicator that pressure advance in general doesn't seem to have any impact at all on the print quality.
Quoting the official Klipper documentation and configuration reference here:

Typical pressure advance values are between 0.050 and 1.000 (the high end usually only with bowden extruders). If there is no significant improvement with a pressure advance up to 1.000, then pressure advance is unlikely to improve the quality of prints. Return to a default configuration with pressure advance disabled.

#pressure_advance_smooth_time: 0.040
#   A time range (in seconds) to use when calculating the average
#   extruder velocity for pressure advance. A larger value results in
#   smoother extruder movements. This parameter may not exceed 200ms.
#   This setting only applies if pressure_advance is non-zero. The
#   default is 0.040 (40 milliseconds).

https://github.com/Klipper3d/klipper/blob/master/docs/Config_Reference.md#extruder
https://github.com/Klipper3d/klipper/blob/master/docs/Pressure_Advance.md

@r3Fuze
Copy link
Contributor Author

r3Fuze commented Jan 19, 2022

Do you have a valid reason why the upper limits should be removed?

In my opinion it doesn't make sense that the interface puts a hard limit on the value when there isn't a hard limit in Klipper.
1.146 was what gave me the best result when tuning. I could probably drop my PA to 1.000 without a noticeable drop in quality but it feels a little weird to change the settings of my printer because the interface (not Klipper) is complaining 😄

Screenshot 2022-01-19 220801

dw-0 added a commit to dw-0/mainsail that referenced this issue Jan 19, 2022
This will reset unconfirmed value changes on any of the machine settings input fields. Fixes the spinner bugs mentioned in mainsail-crew#551. Also improves feedback for the user that values are not applied if not confirmed with ENTER.

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 self-assigned this Jan 19, 2022
@dw-0
Copy link
Member

dw-0 commented Jan 19, 2022

@r3Fuze if you feel "adventurous" you can download and test the automatically generated artifact:
https://github.com/mainsail-crew/mainsail/suites/4994297612/artifacts/146250079

The changes from #555 are applied there and should basically fix all the issues you mentioned.
Also the upper PA limit was removed. The upper limit of the smooth time was kept, because for any value over 0.2 Klipper will return an error. Therefor we keep that upper limit there of course.

@r3Fuze
Copy link
Contributor Author

r3Fuze commented Jan 19, 2022

I've tested the changes and everything works great now 👍

@dw-0
Copy link
Member

dw-0 commented Jan 19, 2022

Thank you for your feedback! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Is: UI/UX Anything referencing UI/UX Prio: 2 Medium 🚦 Status: 1 - Ready ⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants