Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow showing PURGE_FILAMENT and CLEAN_NOZZLE in Extruder panel even if LOAD/UNLOAD_FILAMENT isn't defined #1744

Closed
idmadj opened this issue Jan 12, 2024 · 1 comment · Fixed by #1747
Labels
⚡ Type: Bug Something isn't working

Comments

@idmadj
Copy link

idmadj commented Jan 12, 2024

Mainsail Version:

2.9.1

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

When defining PURGE_FILAMENT and/or CLEAN_NOZZLE macros, but not defining LOAD/UNLOAD_FILAMENT, the buttons are not shown in the extruder panel.

What did you expect to happen instead?

Would love to see the buttons appear.

How to reproduce this bug?

Define PURGE_FILAMENT and/or CLEAN_NOZZLE macros, but don't define LOAD/UNLOAD_FILAMENT. Observe Extruder panel.

Additional information:

Might just need to change line 170 in ExtruderControlPanel.vue to:

        return this.loadFilamentMacro !== undefined || this.unloadFilamentMacro !== undefined || this.purgeFilamentMacro !== undefined || this.cleanNozzleMacro !== undefined

As a workaround, adding an empty LOAD_FILAMENT macro does the trick.

@meteyou
Copy link
Member

meteyou commented Jan 14, 2024

Thx for reporting this bug! i created a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants