G-code viewer artifacts

[Matszwe02]

Mainsail Version:

v2.4.1

Browser:

Firefox

Device:

Desktop PC

Operating System:

Windows

What happened?

Duplicated layers visible on prints in gcode viewer. Tested on Firefox and Opera

What did you expect to happen instead?

Normal rendering

How to reproduce this bug?

It happens from time to time as I try to view 3d models. MainsailOS on RPI 4 (CM4), freshly updated all packages. Slicer Cura 5

Additional information:

No response

[meteyou]

please upload this gcode

[meteyou]

But you must make the bug report in the gcode viewer. Mainsail, use this library: https://github.com/Sindarius/npm_gcodeviewer

[Matszwe02]

3DBenchy.zip

[Sindarius]

I'll look into correcting this issue in the viewer. However, what is happening is your make blob g-code G1 Z4 E40 F50 ; make blob makes the viewer believe that that is the initial layer height because it's the first extrusion of that layer. So when it goes to render your first layer appears oversized in the viewer

With the blob line

Without

[Sindarius]

This PR includes a fix for this issue. #1239

[Matszwe02]

Thanks @Sindarius for spotting the issue!