Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mainmatter/ember-test-selectors
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 17c3cb28c5fbf0d4e124495afb63fa2a35625346
Choose a base ref
..
head repository: mainmatter/ember-test-selectors
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a9713c8d256c0423e448b0f6e0dacd6495dcf4c1
Choose a head ref
Showing with 3 additions and 4 deletions.
  1. +1 −2 README.md
  2. +2 −2 addon/index.js
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -50,8 +50,7 @@ automatically removed from `production` builds:
</article>
```

Once you've done that you can use an attribute selectors to look up the
elements:
Once you've done that you can use attribute selectors to look up the elements:

```js
// in Acceptance Tests:
4 changes: 2 additions & 2 deletions addon/index.js
Original file line number Diff line number Diff line change
@@ -2,8 +2,8 @@ import Ember from 'ember';

const { isNone, deprecate } = Ember;

const message = `Using the "testSelector" helper function is deprecated as it obfuscates the selectors, making the tests harder to follow.
Please write the actual abbribute selectors you need instead, e.g. "[data-test-my-element]" instead of "testSelector('my-element')".`;
const message = `Using the "testSelector" helper function is deprecated as it obfuscates the selectors, making the tests harder to understand.
Please use the actual attribute selectors instead, e.g. "[data-test-my-element]" instead of "testSelector('my-element')".`;

export default function testSelector(key, value) {
deprecate(message, false, {